Open
Conversation
Member
|
Hi Alex, It will be great, if you can add some tests cases. |
Author
|
Hey rbri, I have added several test cases, thank you 👍 |
Member
|
I'm already working on this - will do this slightly different so no direct merge. Please be a bit patient, changes are on the way. |
Member
|
all your tests are added, have done some changes to pass most of them. |
Author
|
Alright thank you for the update rbri 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrections to width calculations: handled some missing cases + corrected some existing widths.