Fixed source-map passed to istanbul-lib-instrument not being a plain object#10
Open
marekdedic wants to merge 1 commit intoJS-DevTools:masterfrom
Open
Fixed source-map passed to istanbul-lib-instrument not being a plain object#10marekdedic wants to merge 1 commit intoJS-DevTools:masterfrom
marekdedic wants to merge 1 commit intoJS-DevTools:masterfrom
Conversation
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I stumbled upon this issue while trying to instrument code previously compiled with svelte. The resulting source-map was an instance of
SourceMap, not a plain object. This led me to babel/babel#11614 and eventually to istanbuljs/istanbuljs#576 where it was stated thatistanbul-lib-instrumentexpects the source map to be a plain object - something which this plugin does not make sure of. This PR fixes that and makes the source-map always be a plain object.