Open
Conversation
Contributor
Author
|
@bagerard And now i need some guidance. How to best approach testing types? For start i just put some tests into 'tests/test_typing.yml`, but running these tests requires mypy and all optional dependencies. And that's probably will be slowest tests, due to mypy being not so fast. If speed is a priority, we can put this into separate folder and run once on single python version. |
Open
|
great work 🦸🏽 |
2da7633 to
82647e2
Compare
82647e2 to
4d03e73
Compare
Contributor
Author
|
@bagerard this is ready for review. That one CI fail looks like unrelated to my changes. But, maybe it's time to drop 3.8 and 3.7 from CI and add 3.12 and 13? I can handle this in separate PR if you wish. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds types.
Partially, from https://github.com/sbdchd/mongo-types/ by @sbdchd
Partially, generated by monkeytype
Partially handwritten and generated by included
gen.pyscript (i'll remove it before merging)I inlined most of the types, but fieds require lot of
@overloads - so i put that into separate.pyi.Note to self, check:
ReferenceField[Image]('Image'))