Adjust import statement so that it work as example#99
Open
reneroboter wants to merge 1 commit intoNativeScript:developfrom
Open
Adjust import statement so that it work as example#99reneroboter wants to merge 1 commit intoNativeScript:developfrom
reneroboter wants to merge 1 commit intoNativeScript:developfrom
Conversation
Member
|
Good catch, I believe the imports are correct for the GitHub sample repo, but not the tutorial content itself - in the repo, there are https://github.com/NativeScript/tutorials/blob/main/plain-tutorial/app/services/index.ts We should either include those in the tutorial text, or drop them and just use full imports. I'm fine with either way... |
rigor789
approved these changes
Aug 31, 2022
Contributor
Author
|
@rigor789 i didn't noticed that there is a repo for the tutorials, therefor a would recommend also to use the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current import statement in the plain tutorial doesn't work. So I adjusted it to a real working example. I'm not a java script expert, maybe it's better to introduce an
index.jsfile, so that the current example work. However I guess this approach is more beginner friendly. Cause it's don't need the knowledge about a import statement with anindex.jsfile.