fix: improve sqrt implementations for f32 and f64 without std#192
Merged
est31 merged 1 commit intoRustAudio:masterfrom Sep 9, 2025
Merged
fix: improve sqrt implementations for f32 and f64 without std#192est31 merged 1 commit intoRustAudio:masterfrom
est31 merged 1 commit intoRustAudio:masterfrom
Conversation
Handles special cases (NaN, zero, negative, infinity) and uses Newton-Raphson refinement for better accuracy. - Updated RMS doc tests to account for >6 decimal precision. - Inlined std sqrt functions for f32 and f64 for performance.
517bf62 to
785ea29
Compare
est31
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI got broken when the
no_stdimplementations forf32andf64were custom-rolled instead of using core intrinsics in this commit: cd8d893. Beyond breaking the CI, RMS values are way off.Problem
The current implementation:
f64Solution
This PR improves the initial guess and uses Newton-Raphson refinement to improve the accuracy to >6 decimal places.