Open
Conversation
vkutuev
requested changes
Jul 31, 2024
vkutuev
left a comment
vkutuev
left a comment
There was a problem hiding this comment.
Also, you must change commit authors!!!
Comment on lines
+26
to
+31
| " cores: int = 1\n", | ||
| " threads: int = 1\n", | ||
| "# running parameters \n", | ||
| "@dataclass\n", | ||
| "class run:\n", |
There was a problem hiding this comment.
Suggested change
| " cores: int = 1\n", | |
| " threads: int = 1\n", | |
| "# running parameters \n", | |
| "@dataclass\n", | |
| "class run:\n", | |
| " cores: int = 1\n", | |
| " threads: int = 1\n", | |
| "\n", | |
| "# running parameters \n", | |
| "@dataclass\n", | |
| "class run:\n", |
tests/opencl/j_stat/statistic.ipynb
Outdated
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "path_to_vortex = \"/home/jblab/ivan_khromov/release/vortex\"\n", |
There was a problem hiding this comment.
Do not use fixed absolute path! It must be calculated from relative.
tests/opencl/j_stat/statistic.ipynb
Outdated
Comment on lines
118
to
120
| " if \"FAILED\" in line: \n", | ||
| " error_message = error_verification(run_params, line[line.find(\"FAILED! - \"):])\n", | ||
| " if \"Error\" in line:\n", |
There was a problem hiding this comment.
It is better to check subprocess return code
tests/opencl/j_stat/statistic.ipynb
Outdated
Comment on lines
91
to
92
| " with open(f\"{path_to_vortex}/tests/opencl/{kernel_name}/main.cc\", 'a') as main:\n", | ||
| " main.write('')" |
tests/opencl/j_stat/statistic.ipynb
Outdated
| "def create_common_h (params: dict, kernel_name: str):\n", | ||
| " file_name = f\"{path_to_vortex}/tests/opencl/{kernel_name}/common.h\"\n", | ||
| " with open(file_name, 'w') as file:\n", | ||
| " text = \"#ifndef COMMON_H\\n\" + \"#define COMMON_H\\n\" + \"\\n\" \n", |
There was a problem hiding this comment.
Suggested change
| " text = \"#ifndef COMMON_H\\n\" + \"#define COMMON_H\\n\" + \"\\n\" \n", | |
| " file.write(\"#ifndef COMMON_H\\n\" + \"#define COMMON_H\\n\" + \"\\n\") \n", |
vano105
force-pushed
the
ivan_khromov
branch
2 times, most recently
from
b62ee90 to
d5a9e5c
Compare
vano105
force-pushed
the
ivan_khromov
branch
3 times, most recently
from
e134ad1 to
8520104
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added four matrix multiplication variants from the tutorial (https://cnugteren.github.io/tutorial/pages/page1.html). The first is naive, the second is related to local memory, the third is about enhancing performance with a single thread, and the fourth uses vector types. A Jupyter notebook has been added for automating the execution and adjustment of vortex parameters, as well as gathering launch statistics in a data frame.