Conversation
…on master, minor cleanups
# Conflicts: # .gitlab-ci-agent.yml # .gitlab-ci-cluster-agent.yml # Development.md # Dockerfiles/local_builder/Dockerfile
LouisParkin
left a comment
LouisParkin
left a comment
There was a problem hiding this comment.
Looks good. Just those ideas for intermission.
| ARG DD_SETUPTOOLS_VERSION=41.0.1 | ||
| ARG IBM_MQ_VERSION=9.1.5.0 | ||
| ARG IBM_MQ_VERSION=9.2.4.0 | ||
| ARG CMAKE_VERSION=3.14.4 | ||
| ARG CLANG_VERSION=8.0.0 |
There was a problem hiding this comment.
Now that I see this a second time in this review, I would offer the advice that we should probably not hard-code these in a Dockerfile, perhaps instead put it in gitlab-ci.yml file, or as gitlab environment variables. Doesn't have to happen today, but I think somebody should make a note (or a Jira ticket - Intermission perhaps).
There was a problem hiding this comment.
Such approach usually leads to situation, when you are unable to do anything locally, without knowing what is in external setup. So I would keep defaults in, as it is now.
There was a problem hiding this comment.
Thanks for the feedback, @LouisParkin !
| ARG DD_SETUPTOOLS_VERSION=41.0.1 | ||
| # 9.1.0.9 | ||
| ARG IBM_MQ_VERSION=9.2.0.0 | ||
| ARG IBM_MQ_VERSION=9.2.4.0 | ||
| ARG CMAKE_VERSION=3.14.4 | ||
| ARG CLANG_VERSION=8.0.0 |
There was a problem hiding this comment.
Same comment as the other Dockerfiles
4 participants
Step 1: Link to Jira issue
https://stackstate.atlassian.net/browse/STAC-15134
Step 2: Description of changes
.gitlab-ci-build-runners.ymlcreates a manual trigger onmasterpipelines.stackstate/stackstate-agent-runner-gitlab:deb7_20211210stackstate/stackstate-agent-runner-gitlab:centos7_20211210stackstate/stackstate-agent-runner-gitlab:deb-rpmpublisher_20211210Step 3: Did you add / update tests for your changes in the right area?
Step 4: I'm confident that everything is properly tested:
I got a PO / QA Approval by:
Step 5: Did you add release notes describing the changes you made?
Step 6: Can we ship this feature to production?