Skip to content

refactor(examples): improve React examples code quality#1121

Open
liwenka1 wants to merge 1 commit intoTanStack:mainfrom
liwenka1:refactor/improve-react-examples
Open

refactor(examples): improve React examples code quality#1121
liwenka1 wants to merge 1 commit intoTanStack:mainfrom
liwenka1:refactor/improve-react-examples

Conversation

@liwenka1
Copy link

@liwenka1 liwenka1 commented Feb 4, 2026

Changes

  • Improve variable naming for better readability (rowsrowSizes, columnscolumnSizes)
  • Remove unused imports and variables (Row type, setData)
  • Fix type safety issues (add explicit String() conversion for symbol keys)
  • Unify array type syntax to Array<T> for consistency
  • Remove unnecessary non-null assertions in makeData.ts
  • Clean up eslint-disable comments after fixing underlying issues

Motivation

These changes improve code quality in the React examples, making them easier to understand for developers learning the library. The naming improvements (rowSizes/columnSizes) more clearly indicate that these arrays contain dimension values rather than the actual row/column components.

Testing

  • All modified examples tested locally
  • No runtime behavior changes
  • Lint errors resolved

- Improve variable naming for better readability (rows to rowSizes, columns to columnSizes)

- Remove unused imports and variables (Row type, setData)

- Fix type safety issues (add explicit String conversion for symbol keys)

- Unify array type syntax to Array<T> for consistency

- Remove unnecessary non-null assertions in makeData.ts

- Clean up eslint-disable comments after fixing underlying issues
@changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2026

⚠️ No Changeset found

Latest commit: a4c736c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant