refactor(examples): improve React examples code quality#1121
Open
liwenka1 wants to merge 1 commit intoTanStack:mainfrom
Open
refactor(examples): improve React examples code quality#1121liwenka1 wants to merge 1 commit intoTanStack:mainfrom
liwenka1 wants to merge 1 commit intoTanStack:mainfrom
Conversation
- Improve variable naming for better readability (rows to rowSizes, columns to columnSizes) - Remove unused imports and variables (Row type, setData) - Fix type safety issues (add explicit String conversion for symbol keys) - Unify array type syntax to Array<T> for consistency - Remove unnecessary non-null assertions in makeData.ts - Clean up eslint-disable comments after fixing underlying issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
rows→rowSizes,columns→columnSizes)Rowtype,setData)String()conversion for symbol keys)Array<T>for consistencymakeData.tsMotivation
These changes improve code quality in the React examples, making them easier to understand for developers learning the library. The naming improvements (
rowSizes/columnSizes) more clearly indicate that these arrays contain dimension values rather than the actual row/column components.Testing