Open
Conversation
kripken
reviewed
Nov 24, 2025
| info.canChangeState = true; | ||
| info.isTopMostRuntime = true; | ||
| } else if (target->base == GET_STATE) { | ||
| info.canChangeState = false; |
Member
There was a problem hiding this comment.
I think this is wrong - it will undo a previous true, forgetting that another call can change the state.
That is, these flags start as false, and should only ever change to true.
Author
There was a problem hiding this comment.
That makes sense; this branch is necessary though to prevent falling through to the unreachable, so I’ll add a condition to the outer scope.
kripken
reviewed
Nov 24, 2025
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Please add a test. The existing ones are in ./test/lit/passes/asyncify*, so a new one alongside them makes sense, unless you find one that this can fit naturally inside.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7317