Open
Conversation
stevenfontanella
force-pushed
the
initializer
branch
from
c05f84e to
75a120a
Compare
stevenfontanella
changed the title
tlively
reviewed
Jan 30, 2026
| // removed during optimization | ||
| // - there's no point in logging anyref because it is opaque | ||
| // - don't bother logging tuples | ||
| loggableTypes(concat( |
Member
There was a problem hiding this comment.
Another way to do this that doesn't put as much logic into the initializer list is to call out to static methods that return the initialized members.
Member
There was a problem hiding this comment.
Good idea, that sounds like it might read better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #8253 (comment). Allow us to declare
loggableTypesandatomicMemoryOrdersas const to prevent them from being mutated by mistake.