Update README.md: no java HelloWorldApp.java#611
Open
davidkhala wants to merge 1 commit intoactions:mainfrom
Open
Update README.md: no java HelloWorldApp.java#611davidkhala wants to merge 1 commit intoactions:mainfrom
java HelloWorldApp.java#611davidkhala wants to merge 1 commit intoactions:mainfrom
Conversation
A confusion introduced by running `java HelloWorldApp.java` I believe the file is not an artifact of `setup-java`, thus user should provide it. But there is no tips in the guide that user should prepare it in advance. Directly copy the code snippets will introduce a straightforward error, which should not happen in a guide.
Author
|
Is there anyone available for a review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A confusion introduced by running
java HelloWorldApp.javaI believe the file is not an artifact of
setup-java, thus user should provide it. But there is no tips in the guide that user should prepare it in advance.Directly copy the code snippets will introduce a straightforward error, which should not happen in a guide.