Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds caching support for the Mill build tool, expanding the action’s compatibility with popular JVM build tools.
- Adds Mill as a supported package manager with appropriate cache paths and file patterns in the source code.
- Introduces tests for Mill caching behaviors (error throwing, cache restoration consistency, etc.).
- Updates the documentation and end-to-end workflow to include examples and tests for Mill caching.
Reviewed Changes
Copilot reviewed 5 out of 9 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/cache.ts | Adds Mill caching support to the PackageManager interface and supported array. |
| tests/cache.test.ts | Implements unit tests to verify Mill caching behavior. |
| README.md | Updates docs to include Mill as a supported package manager and usage examples. |
| .github/workflows/e2e-cache.yml | Adds e2e test workflow steps for saving/restoring Mill cache across OSes. |
Files not reviewed (4)
- tests/cache/mill/.gitignore: Language not supported
- tests/cache/mill/.mill-version: Language not supported
- tests/cache/mill/build.sc: Language not supported
- tests/cache/mill/mill: Language not supported
clintval
commented
May 6, 2025
| exit 1 | ||
| fi | ||
| - name: Check files to cache on ubuntu-latest | ||
| if: matrix.os == 'ubuntu-latest' |
Author
There was a problem hiding this comment.
I copied these patterns from above and notice a potential bug.
The matrix defines ubuntu-22.04 but the conditional here is still set to ubuntu-latest. I imagine this was not intentional. Is there a reason to pin to 22.04? If not, I'd vote reverting back to ubuntu-latest all over.
lihaoyi
reviewed
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Similar to Gradle, Maven, and sbt, I am hoping to see Mill cache support.
Mill is becoming a popular JVM build tool so I hope this is a welcome addition.
I have not contributed to this project before so please let me know if I missed anything!
Speaking of, how do I run automated tests on this branch?
Check list: