Skip to content

engine-schema: fix systemvm template upgrade for missing or unused hypervisor type#12092

Draft
shwstppr wants to merge 4 commits intoapache:4.20from
shapeblue:imprv-sysvmactvhyp
Draft

engine-schema: fix systemvm template upgrade for missing or unused hypervisor type#12092
shwstppr wants to merge 4 commits intoapache:4.20from
shapeblue:imprv-sysvmactvhyp

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Nov 18, 2025

Description

Fixes #12077

Consider hosts instead of clusters to get the list of hypervisor and architecture combinations.
Improve checking bundled system vm templates.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

hypervisor type

Fixes apache#12077

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr marked this pull request as draft November 18, 2025 13:15
@shwstppr shwstppr closed this Nov 20, 2025
@shwstppr shwstppr reopened this Nov 20, 2025
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.27%. Comparing base (d26122b) to head (9e387f9).
⚠️ Report is 111 commits behind head on 4.20.

Files with missing lines Patch % Lines
...om/cloud/upgrade/SystemVmTemplateRegistration.java 63.63% 3 Missing and 1 partial ⚠️
...ain/java/com/cloud/storage/StorageManagerImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #12092      +/-   ##
============================================
+ Coverage     16.18%   16.27%   +0.08%     
- Complexity    13305    13432     +127     
============================================
  Files          5657     5661       +4     
  Lines        498459   500018    +1559     
  Branches      60492    60716     +224     
============================================
+ Hits          80694    81362     +668     
- Misses       408783   409584     +801     
- Partials       8982     9072      +90     
Flag Coverage Δ
uitests 4.15% <ø> (+0.14%) ⬆️
unittests 17.12% <58.33%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@apache apache deleted a comment from blueorangutan Nov 24, 2025
@apache apache deleted a comment from blueorangutan Nov 24, 2025
@shwstppr shwstppr requested a review from Pearl1594 November 24, 2025 06:33
@shwstppr shwstppr linked an issue Nov 27, 2025 that may be closed by this pull request
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@apache apache deleted a comment from blueorangutan Feb 6, 2026
@apache apache deleted a comment from blueorangutan Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SystemVM template registration failure in upgrading to 4.22

1 participant