Skip to content

[Oracle] Support hierarchical queries#2185

Merged
iffyio merged 16 commits intoapache:mainfrom
xitep:main
Feb 5, 2026
Merged

[Oracle] Support hierarchical queries#2185
iffyio merged 16 commits intoapache:mainfrom
xitep:main

Conversation

@xitep
Copy link
Contributor

@xitep xitep commented Jan 30, 2026

  • this is merely building on top of already existing "connect by" functionality for snowflake :)
  • and making the start with clause optional as per docs and encountered in the wild

if let Some(ref connect_by) = self.connect_by {
SpaceOrNewline.fmt(f)?;
connect_by.fmt(f)?;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can't verify this change for snowflake, but this doc indicates to me that it's ok

@xitep xitep force-pushed the main branch 2 times, most recently from c9858a3 to 6b8bddd Compare February 3, 2026 19:13
@xitep xitep requested a review from iffyio February 3, 2026 19:13
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @xitep!

@iffyio iffyio added this pull request to the merge queue Feb 5, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Feb 5, 2026
@iffyio
Copy link
Contributor

iffyio commented Feb 5, 2026

@xitep could you take a look at the conflicts when you have some time?

@xitep
Copy link
Contributor Author

xitep commented Feb 5, 2026

should be good now, i rebased. please squash merge the whole pile of small commits. last but not least, many thanks for your support @iffyio

@iffyio iffyio added this pull request to the merge queue Feb 5, 2026
Merged via the queue into apache:main with commit d7f56e8 Feb 5, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants