[Improve](StreamingJob) add more metrics to observe the streaming job#60493
Open
JNSimba wants to merge 5 commits intoapache:masterfrom
Open
[Improve](StreamingJob) add more metrics to observe the streaming job#60493JNSimba wants to merge 5 commits intoapache:masterfrom
JNSimba wants to merge 5 commits intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
There was a problem hiding this comment.
Pull request overview
Adds new FE-side metrics to improve observability of streaming insert jobs, along with a regression test that validates the metrics are exposed via the FE /metrics endpoint.
Changes:
- Registers new streaming job counter metrics in
MetricRepoand adds streaming job state gauges. - Increments the new counters from
StreamingInsertJoblifecycle points (meta fetch, task success/failure, offset commit). - Adds a MySQL CDC regression test that polls FE metrics until all expected streaming-job metrics are present.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| regression-test/suites/job_p0/streaming_job/cdc/test_streaming_mysql_job_metrics.groovy | New regression test validating FE exports the expected streaming job metrics. |
| fe/fe-core/src/main/java/org/apache/doris/metric/MetricRepo.java | Registers streaming job counters and adds streaming job state gauge metrics. |
| fe/fe-core/src/main/java/org/apache/doris/job/extensions/insert/streaming/StreamingInsertJob.java | Emits streaming job metric increments during meta fetch, task completion, and offset/stat updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
regression-test/suites/job_p0/streaming_job/cdc/test_streaming_mysql_job_metrics.groovy
Show resolved
Hide resolved
...-core/src/main/java/org/apache/doris/job/extensions/insert/streaming/StreamingInsertJob.java
Show resolved
Hide resolved
...-core/src/main/java/org/apache/doris/job/extensions/insert/streaming/StreamingInsertJob.java
Show resolved
Hide resolved
Member
Author
|
run buildall |
TPC-H: Total hot run time: 31401 ms |
ClickBench: Total hot run time: 29.11 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Add more metrics to observe the streaming job:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)