[Opt](load) Support using AES_ENCRYPT with internal custom ENCRYPTKEY in stream load and routine load#60503
Open
bobhan1 wants to merge 2 commits intoapache:masterfrom
Open
[Opt](load) Support using AES_ENCRYPT with internal custom ENCRYPTKEY in stream load and routine load#60503bobhan1 wants to merge 2 commits intoapache:masterfrom
AES_ENCRYPT with internal custom ENCRYPTKEY in stream load and routine load#60503bobhan1 wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31980 ms |
gavinchou
previously approved these changes
Feb 4, 2026
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
ClickBench: Total hot run time: 28.75 s |
AES_ENCRYPT with internal custom ENCRYPTKEY in stream loadAES_ENCRYPT with internal custom ENCRYPTKEY in stream load and routine load
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31793 ms |
ClickBench: Total hot run time: 28.51 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
dbda566 to
a89c3c1
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31149 ms |
ClickBench: Total hot run time: 28.76 s |
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Summary
Support using
CREATE ENCRYPTKEYdefined custom keys (viaKEY db.keynamesyntax) in thecolumnsparameter of Stream Load and Routine Load.Problem:
Previously,
EncryptKeyRefwas only folded to the actual key string during theFoldConstantRulephase, which was skipped in load planning (setDebugSkipFoldConstant(true)), causing aCould not find function encryptkeyreferror on BE.Solution:
RewriteEncryptKeyRefrule inNereidsLoadUtilsto foldEncryptKeyRefbeforeExpressionNormalization, bypassing the skip-fold-constant flagCurrentUserIdentityin non-cloud mode duringRoutineLoadJob.plan()Changes
FE Core
RewriteEncryptKeyRefinner class that directly invokesFoldConstantRuleOnFE.VISITOR_INSTANCEto foldEncryptKeyReftoStringLiteral, placed beforeExpressionNormalizationin the analyzer pipelineConnectContext.setCurrentUserIdentity()in non-cloud mode path ofplan()method, so that privilege checks during expression rewrite have proper user identityRegression Tests
AES_ENCRYPTin Stream Load columns with both direct key string andKEY db.keynamesyntaxAES_ENCRYPTin Routine Load columns with both direct key string andKEY db.keynamesyntaxExample Usage
Test Plan
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)