[SPARK-55347][SQL] Pass Generated Column as Expression to DSV2#54126
Open
szehon-ho wants to merge 2 commits intoapache:masterfrom
Open
[SPARK-55347][SQL] Pass Generated Column as Expression to DSV2#54126szehon-ho wants to merge 2 commits intoapache:masterfrom
szehon-ho wants to merge 2 commits intoapache:masterfrom
Conversation
JIRA Issue Information=== Improvement SPARK-55347 === This comment was automatically generated by GitHub Actions |
szehon-ho
force-pushed
the
analyze_generated_column
branch
from
5c1f4ff to
190499f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This change passes a DSV2 Expression (from an analyzed generated column Expression) to the DSV2 API.
It also cleans up the code. Previously, the generation expression is analyzed by an independent analyzer. Now, it is inline (similar to how constraint expressions are analyzed). This makes it easier to run optimizer rules to constant fold the expression, before they are passed into DSV2.
Why are the changes needed?
Code cleanup and to make DSV2 data source able to work with DSV2 Expression API for generated columns
Does this PR introduce any user-facing change?
Some error messages may change, but overall should be the same.
How was this patch tested?
Added new tests in DataSourceV2DataFrameSuite, and changed error case expectations in existing tests.
Was this patch authored or co-authored using generative AI tooling?
Some claude 4.5 opus, but hand tuned