Generate complete clean-target headers and drop test patches

[shai-almog]

Motivation

• Ensure the Bytecode translator emits self-contained, correct C/Obj-C headers so generated projects build without test-time header fixes.
• Prevent tests from mutating generated translator output at runtime, which masked generator bugs and caused flaky behavior.

Description

• Add an Objective-C forward declaration for NSString to cn1_globals.h so generated headers are self-contained for Obj-C builds (vm/ByteCodeTranslator/src/cn1_globals.h).
• Unconditionally emit virtual method function-pointer typedefs, wrappers and header declarations from the translator by removing the virtualMethodsInvoked guard in appendVirtualMethodC/appendVirtualMethodHeader (vm/ByteCodeTranslator/src/com/codename1/tools/translator/BytecodeMethod.java).
• Remove test-time patching helpers and calls that modified generated headers (remove patchCn1Globals and ensureReentrantReadWriteLockHeader usages), and update integration tests to build the generated source as-is (vm/tests/src/test/java/com/codename1/tools/translator/*).
• Update CompilerHelper and several integration tests to stop calling the removed patch routines so tests no longer alter translator output (vm/tests/.../CompilerHelper.java, BytecodeInstructionIntegrationTest.java, CleanTargetIntegrationTest.java, FileClassIntegrationTest.java, LambdaIntegrationTest.java, LockIntegrationTest.java, ReadWriteLockIntegrationTest.java, StampedLockIntegrationTest.java).

Testing

• No automated tests were executed as part of this change (no CI/test run was requested).

---

Codex Task

[github-actions]

✅ Continuous Quality Report

Test & Coverage

• ✅ Tests: 2292 total, 0 failed, 0 skipped
• 📊 Line coverage: 52.78% [HTML preview] [Download]
  • Lowest covered classes
    • com.codename1.io.rest.RequestBuilder$FetchAsPropertyListActionListener – 0.00%
    • com.codename1.io.rest.RequestBuilder$FetchAsPropertiesActionListener – 0.00%
    • com.codename1.ui.Display$EdtException – 0.00%
    • com.codename1.ui.BrowserWindow$BrowserForm – 0.00%
    • com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
    • com.codename1.io.rest.RequestBuilder$GetAsStringAsyncImplActionListener – 0.00%
    • com.codename1.io.rest.RequestBuilder$GetAsJsonMapActionListener – 0.00%
    • com.codename1.payment.Purchase$SynchronizeReceiptsSyncRunnable – 0.00%
    • com.codename1.io.rest.RequestBuilder$GetAsBytesAsyncImplActionListener – 0.00%
    • com.codename1.io.rest.RequestBuilder$FetchAsJsonMapActionListener – 0.00%

Static Analysis

• SpotBugs [HTML preview] [Download]
  • ❌ ByteCodeTranslator: 122 findings (High: 6, Normal: 84, Low: 32)
    • Top findings
      • High: com/codename1/tools/translator/ByteCodeTranslator.java:579 – Found reliance on default encoding in com.codename1.tools.translator.ByteCodeTranslator.writeCmakeProject(File, File, String): new java.io.FileWriter(File) (rule: DM_DEFAULT_ENCODING)
      • High: com/codename1/tools/translator/ByteCodeTranslator.java:660 – Found reliance on default encoding in com.codename1.tools.translator.ByteCodeTranslator.readFileAsStringBuilder(File): new String(byte[]) (rule: DM_DEFAULT_ENCODING)
      • High: com/codename1/tools/translator/ByteCodeTranslator.java:690 – Found reliance on default encoding in com.codename1.tools.translator.ByteCodeTranslator.replaceInFile(File, String[]): new java.io.FileWriter(File) (rule: DM_DEFAULT_ENCODING)
      • …and 119 more
  • ❌ android: 444 findings (High: 42, Normal: 197, Low: 205)
    • Top findings
      • High: CodenameOne/src/com/codename1/impl/CodenameOneThread.java:48 – com.codename1.impl.CodenameOneThread.STACK_FRAME_SIZE isn't final but should be (rule: MS_SHOULD_BE_FINAL)
      • High: com/codename1/impl/android/AndroidImplementation.java:1059 – Write to static field com.codename1.impl.android.AndroidImplementation.context from instance method com.codename1.impl.android.AndroidImplementation.setContext(Context) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
      • High: com/codename1/impl/android/AndroidImplementation.java:10706 – com.codename1.impl.android.AndroidImplementation.performBackgroundFetch(boolean) might ignore java.lang.Exception (rule: DE_MIGHT_IGNORE)
      • …and 441 more
  • ❌ codenameone-maven-plugin: 537 findings (High: 37, Normal: 327, Low: 173)
    • Top findings
      • High: com/codename1/builders/AndroidGradleBuilder.java:1553 – Found reliance on default encoding in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest): String.getBytes() (rule: DM_DEFAULT_ENCODING)
      • High: com/codename1/builders/AndroidGradleBuilder.java:1982 – Found reliance on default encoding in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest): new java.io.FileReader(File) (rule: DM_DEFAULT_ENCODING)
      • High: com/codename1/builders/AndroidGradleBuilder.java:3989 – Found reliance on default encoding in com.codename1.builders.AndroidGradleBuilder.extract(InputStream, File, String): String.getBytes() (rule: DM_DEFAULT_ENCODING)
      • …and 534 more
  • ✅ core-unittests: 0 findings (no issues)
  • ❌ ios: 127 findings (High: 5, Normal: 75, Low: 47)
    • Top findings
      • High: com/codename1/impl/ios/IOSImplementation.java:1218 – com.codename1.impl.ios.IOSImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
      • High: com/codename1/impl/ios/IOSImplementation.java:127 – com.codename1.impl.ios.IOSImplementation.nativeInstance isn't final but should be (rule: MS_SHOULD_BE_FINAL)
      • High: com/codename1/impl/ios/IOSImplementation.java:212 – Write to static field com.codename1.impl.ios.IOSImplementation.instance from instance method com.codename1.impl.ios.IOSImplementation.init(Object) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
      • …and 124 more
• ✅ PMD: 0 findings (no issues) [Report archive]
• ✅ Checkstyle: 0 findings (no issues) [Report archive]

Generated automatically by the PR CI workflow.

[github-actions]

✅ ByteCodeTranslator Quality Report

Test & Coverage

• ✅ Tests: 135 total, 0 failed, 2 skipped

Benchmark Results

• Execution Time: 9921 ms

• Hotspots (Top 20 sampled methods):

  • 22.37% java.lang.String.indexOf (385 samples)
  • 18.13% com.codename1.tools.translator.Parser.isMethodUsed (312 samples)
  • 15.46% com.codename1.tools.translator.Parser.addToConstantPool (266 samples)
  • 8.60% java.util.ArrayList.indexOf (148 samples)
  • 4.59% java.lang.Object.hashCode (79 samples)
  • 3.78% com.codename1.tools.translator.ByteCodeClass.calcUsedByNative (65 samples)
  • 2.67% com.codename1.tools.translator.ByteCodeClass.fillVirtualMethodTable (46 samples)
  • 2.56% com.codename1.tools.translator.BytecodeMethod.optimize (44 samples)
  • 2.44% java.lang.System.identityHashCode (42 samples)
  • 1.45% com.codename1.tools.translator.BytecodeMethod.equals (25 samples)
  • 1.34% java.io.FileOutputStream.writeBytes (23 samples)
  • 0.93% com.codename1.tools.translator.Parser.cullMethods (16 samples)
  • 0.93% com.codename1.tools.translator.Parser.generateClassAndMethodIndexHeader (16 samples)
  • 0.81% java.lang.StringBuilder.append (14 samples)
  • 0.76% java.io.FileOutputStream.open0 (13 samples)
  • 0.76% com.codename1.tools.translator.BytecodeMethod.isMethodUsedByNative (13 samples)
  • 0.70% com.codename1.tools.translator.Parser.getClassByName (12 samples)
  • 0.64% com.codename1.tools.translator.BytecodeMethod.addToConstantPool (11 samples)
  • 0.64% com.codename1.tools.translator.ByteCodeClass.markDependent (11 samples)
  • 0.58% java.io.FileInputStream.open0 (10 samples)

• ⚠️ Coverage report not generated.

Static Analysis

• ✅ SpotBugs: no findings (report was not generated by the build).
• ⚠️ PMD report not generated.
• ⚠️ Checkstyle report not generated.

Generated automatically by the PR CI workflow.

[shai-almog]

Compared 30 screenshots: 30 matched.
✅ Native Android screenshot tests passed.

Benchmark Results

• VM Translation Time: 298 seconds
• Compilation Time: 362 seconds

Detailed Performance Metrics

Metric	Duration
Build Time Statistics
Setup & Unzip	28745 ms
Extract Extensions	22 ms
Google Services Setup	3 ms
Scan Classes	763 ms
Extract Libs	706 ms
Inject Build Hints	35 ms
Generate Unit Tests	2 ms
Generate Stubs	1010 ms
Compile Stubs	2155 ms
Generate Icons	1008 ms
Prepare ParparVM	187 ms
ParparVM Execution	170586 ms
Post-VM Setup	167 ms
CocoaPods	5320 ms
Finalize	15 ms
Total Time	210725 msMaven Overhead : 88000 ms
CocoaPods Install (Script)	1000 ms
Simulator Boot	119000 ms
Simulator Boot (Run)	3000 ms
App Install	15000 ms
App Launch	4000 ms
Test Execution	178000 ms