Fix panic index out of range (#289)#291
Open
pluvivanto wants to merge 2 commits intodanvergara:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This is PR for issue 289.
I tried to replicate this in my windows env (win11 25H2 w/ windows terminal v1.23.20211.0) but couldn't. idk if it's because of the windows/terminal version or because my windows isn't English-based.
But according to the log in that issue, the panic came from
updateTableMetadataOnChangewhen the tables list is empty.The simplest fix would be adding checks before the GetItemText&GetCurrentItem call, which I did in this PR. Though we might still want to dig into why the table list is empty in the first place.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Ran unit and integration tests.
I also changed
=?inDB_USER=?postgresto?=because the integration tests were failing. Pretty sure it was a typo, but feel free to drop that if it wasn't.Checklist: