Adding support for colors in ReactNative #728
Open
jrobber wants to merge 1 commit intodebug-js:masterfrom
Open
Adding support for colors in ReactNative #728jrobber wants to merge 1 commit intodebug-js:masterfrom
jrobber wants to merge 1 commit intodebug-js:masterfrom
Conversation
ReactNative renders in a document-less mode, but goes through the browser for their live builds. Fortunately they tag the navigator as ReactNative making this easy to check for.
Author
|
With this change you can set the environment variables before you import debug anywhere (like in index.js or in a config.js) like so : You could tie those to variables in the manifest if you want to, but the main value of this in ReactNative is development debugging, not distributed. This will only allow the logs to be colored in the browser terminal. React-native/expo need to make changes that convert browser colors to server colors if debug is going to work in their terminals. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReactNative renders in a document-less mode, but goes through the browser for their live builds.
Fortunately they tag the navigator as ReactNative making this easy to check for.