Add server command queue to ChannelsLiveServerTestCase to allow clean…#2209
Open
johanneswilm wants to merge 2 commits intodjango:mainfrom
Open
Add server command queue to ChannelsLiveServerTestCase to allow clean…#2209johanneswilm wants to merge 2 commits intodjango:mainfrom
johanneswilm wants to merge 2 commits intodjango:mainfrom
Conversation
This was referenced Dec 17, 2025
Member
|
Hey @johanneswilm. Thanks for this. Initial thought: it looks overly complex. Not a criticism per se. More, I think we made a misstep, and that's an indication of that. I'll have a play over the holidays |
Author
|
I agree that it looks complex. I tried to make it as simple as possible and change as little as possible. But there are other solutions - such as rolling back the changes introduced in cd44771 to make the entire test class use the same Daphne process. I am not sure what the benefits of doing that are and whether those benefits outweigh issues such as this one. |
Member
|
No me neither currently 😜 Let me think about it. Thanks for the efforts. Really helpful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a possible solution for #2208 in combination with johanneswilm/django-channels-contenttype-test#1