fix: add support for alpha() color function
#107
+32
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
The |
nzakas
previously approved these changes
Jan 30, 2026
Member
nzakas
left a comment
nzakas
left a comment
There was a problem hiding this comment.
This looks really good, thank you!
Would like @SwetaTanwar to review before merging.
Member
|
Can you double-check the lint failures? |
Pull Request Test Coverage Report for Build 21523542999Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Author
|
Thank you for reviewing and approving! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Added support for the
alpha()function, which was the last remaining item from issue #82.What changes did you make? (Give an overview)
In addition to setting the type definition for the
alpha()function in patch.json, I also updated the color-function definition because thealpha()function was missing from the color-function definition in mdn-data/css.I also added tests.
Related Issues
fixes #82
Is there anything you'd like reviewers to focus on?
This is my first time contributing to the ESLint community, so please feel free to point out anything missing.
Thank you in advance!