lastIndexOf: fix byteOffset when encoding passed as second arg#369
Open
arantes555 wants to merge 1 commit intofeross:masterfrom
Open
lastIndexOf: fix byteOffset when encoding passed as second arg#369arantes555 wants to merge 1 commit intofeross:masterfrom
arantes555 wants to merge 1 commit intofeross:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
buffer.lastIndexOfbehaves differently than node's Buffer whenencodingis passed as second argument.To reproduce the issue :
The problem comes from the fact that, in
bidirectionalIndexOf, whentypeof byteOffset === 'string, the code setsbyteOffset = 0. This is perfectly fine forindexOf, but breakslastIndexOf(as the correct value would be the end of the buffer).This PR fixes this, by setting
byteOffset = undefinedinstead (this is what NodeJS does : https://github.com/nodejs/node/blob/main/lib/buffer.js#L980 ). It also adds a test for this.