Open
Conversation
xperiandri
force-pushed
the
ID_type_deserialization_fix
branch
from
d9061cf to
8fd8170
Compare
xperiandri
commented
Dec 15, 2022
Collaborator
Author
xperiandri
left a comment
xperiandri
left a comment
There was a problem hiding this comment.
@njlr any opinions?
tests/FSharp.Data.GraphQL.IntegrationTests/FSharp.Data.GraphQL.IntegrationTests.fsproj
Outdated
Show resolved
Hide resolved
tests/FSharp.Data.GraphQL.IntegrationTests/ResponseJsonTests.fs
Outdated
Show resolved
Hide resolved
xperiandri
force-pushed
the
ID_type_deserialization_fix
branch
from
a024d30 to
48c7715
Compare
Collaborator
Author
|
@njlr review, please |
xperiandri
force-pushed
the
ID_type_deserialization_fix
branch
from
48c7715 to
d2a746e
Compare
Collaborator
|
How did this fail prior to this PR? |
Contributor
|
LGTM 👍 |
Collaborator
|
@njlr can you approve again? I accidentally closed the Pull Request. |
Contributor
|
@ivelten I don't have permissions @xperiandri Can you help? |
Collaborator
Author
|
This needs to be rebased or applied on top of #418 |
xperiandri
force-pushed
the
ID_type_deserialization_fix
branch
from
ee9baf6 to
5e02ca2
Compare
xperiandri
force-pushed
the
dev
branch
4 times, most recently
from
c8b3525 to
0810527
Compare
xperiandri
force-pushed
the
dev
branch
2 times, most recently
from
14aa27a to
3ba4016
Compare
xperiandri
force-pushed
the
dev
branch
2 times, most recently
from
1737829 to
246d6c0
Compare
xperiandri
force-pushed
the
dev
branch
2 times, most recently
from
0dd4372 to
81bc85e
Compare
xperiandri
force-pushed
the
ID_type_deserialization_fix
branch
from
5e02ca2 to
99dc46b
Compare
Deserialization of ID types caused an exception if the field was nullable.
xperiandri
force-pushed
the
ID_type_deserialization_fix
branch
from
99dc46b to
8f459ab
Compare
xperiandri
force-pushed
the
dev
branch
5 times, most recently
from
d90f0e9 to
434b4be
Compare
xperiandri
force-pushed
the
dev
branch
3 times, most recently
from
f3a1bf8 to
9d4b950
Compare
xperiandri
force-pushed
the
dev
branch
2 times, most recently
from
6dc591e to
85a9d8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase of #262