Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a typo in two markdown files by correcting the misspelling of "occured" to "occurred".
- Updated RadioLib documentation to fix the typo.
- Updated the Chengdu Pinguo Tech Co. document with the correct spelling.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| 2019/07/2019-07-23-RadioLib.md | Corrected the typo in the narrative text. |
| 2017/2017-05-22-ChengduPinguoTechCo.md | Fixed the misspelling of "occurred" in context. |
|
|
||
| **Please provide a detailed description of the original copyrighted work that has allegedly been infringed. If possible, include a URL to where it is posted online.** | ||
| The work in question is a C/C++ library RadioLib (available at https://github.com/jgromes/RadioLib). It is an embedded driver for various wireless communication modules. Amongst the supported wireless modules is the SX126x family of LoRa radio modules. It has recently occured to me that a different GitHub project (https://github.com/tinytronix/SX126x) is using substantial parts of RadioLib code without any mention of RadioLib or its original license. RadioLib is licensed under the MIT License, which clearly states that: "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software." I firmly believe that this use of RadioLib is in violation of its license. | ||
| The work in question is a C/C++ library RadioLib (available at https://github.com/jgromes/RadioLib). It is an embedded driver for various wireless communication modules. Amongst the supported wireless modules is the SX126x family of LoRa radio modules. It has recently occurred to me that a different GitHub project (https://github.com/tinytronix/SX126x) is using substantial parts of RadioLib code without any mention of RadioLib or its original license. RadioLib is licensed under the MIT License, which clearly states that: "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software." I firmly believe that this use of RadioLib is in violation of its license. |
There was a problem hiding this comment.
Corrected the typo from 'occured' to 'occurred'.
| My name is [Private], an programmer in Chengdu Pinguo Tech Co, Ltd., which focus on studying real-time image processing technoloies. | ||
|
|
||
| Last year, I uploaded our company's private code in Github . Because I am not familiar with Github website setting, I made a mistake to put it on the public website (https://github.com/pinguo) as public code. However, it is private code which belongs to our company. I was intended to put it on our private website （https://github.com/PGWireless）. What's worse , I found that 2 subscribers (https://github.com/Honsec/PGSkinPrettifyEngine、https://github.com/alemic/PGSkinPrettifyEngine ) have forked our code. Recently we found that the same SDK occured in the market and someone use it to sale. It has already caused a huge loss to our company and our customers. | ||
| Last year, I uploaded our company's private code in Github . Because I am not familiar with Github website setting, I made a mistake to put it on the public website (https://github.com/pinguo) as public code. However, it is private code which belongs to our company. I was intended to put it on our private website （https://github.com/PGWireless）. What's worse , I found that 2 subscribers (https://github.com/Honsec/PGSkinPrettifyEngine、https://github.com/alemic/PGSkinPrettifyEngine ) have forked our code. Recently we found that the same SDK occurred in the market and someone use it to sale. It has already caused a huge loss to our company and our customers. |
There was a problem hiding this comment.
Corrected the typo from 'occured' to 'occurred'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix typo from
occuredtooccurred