Revert "Add *.snk strong name key files"#4777
Open
Youssef1313 wants to merge 1 commit intogithub:mainfrom
Open
Revert "Add *.snk strong name key files"#4777Youssef1313 wants to merge 1 commit intogithub:mainfrom
Youssef1313 wants to merge 1 commit intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts a previous change (PR #2483) that added a commented-out rule for *.snk (strong name key) files in the VisualStudio gitignore template. The revert aligns with Microsoft's official guidance that recommends adding strong naming key pairs to source control. The change cleanly removes the 4-line comment block that warned against including strong name files.
- Removes the commented-out
#*.snkrule and its explanatory comment - Aligns with Microsoft's strong naming guidance for .NET libraries
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
This reverts #2483 per discussion in there.
Links to documentation supporting these rule changes
https://learn.microsoft.com/dotnet/standard/library-guidance/strong-naming
Merge and Approval Steps