Feature: Add support for repository variables#635
Open
primetheus wants to merge 2 commits intogithub:main-enterprisefrom
Open
Feature: Add support for repository variables#635primetheus wants to merge 2 commits intogithub:main-enterprisefrom
primetheus wants to merge 2 commits intogithub:main-enterprisefrom
Conversation
decyjphr
reviewed
Dec 21, 2024
| * @returns {Array.<object>} Returns a list of variables that exist in a repository | ||
| */ | ||
| find () { | ||
| const result = async () => { |
Collaborator
There was a problem hiding this comment.
The code was failing the tests, perhaps the find method could be rewritten as
Suggested change
| const result = async () => { | |
| async find () { | |
| const res = await this.github.request('GET /repos/:org/:repo/actions/variables', { | |
| org: this.repo.owner, | |
| repo: this.repo.repo | |
| }) | |
| const properties = res.data.map(d => { return { name: d.property_name, value: d.value } }) | |
| return properties | |
| } |
Contributor
|
@primetheus could you also update the related docs? Like provide examples to make the distinction between environment variables and GH Actions variables more clear (#820)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for repository-level variables that can be used outside of a specific deployment environment.
cc: @decyjphr