feat! Add IssueListByOrgOptions and update ListByOrg to use it#3694
feat! Add IssueListByOrgOptions and update ListByOrg to use it#3694cpanato wants to merge 1 commit intogoogle:masterfrom
IssueListByOrgOptions and update ListByOrg to use it#3694Conversation
|
cc @gmlewis |
|
Just FYI - I lost write access to this repo and this may cause unexpected delays for which I apologize. |
|
no worries, thanks for the heads up |
|
@gmlewis hello any updates on your permission? |
|
thanks, that is sad :( |
gmlewis
changed the title
IssueListByRepoOptions and update ListByOrg to use it
gmlewis
changed the title
IssueListByRepoOptions and update ListByOrg to use itIssueListByOrgOptions and update ListByOrg to use it
gmlewis
added
NeedsReview
|
@cpanato - do you have time to resolve conflicts in this PR, or would you rather I do that? |
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @cpanato!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging. (Either you or I could resolve conflicts as previously mentioned.)
@stevehipwell and/or @alexandear - might you have time for a code review? Thank you!
…pe filter as well Signed-off-by: Carlos Panato <[email protected]>
|
@gmlewis PTAL,rebased |
| return issues, resp, nil | ||
| } | ||
|
|
||
| // IssueListByOrgOptions specifies the optional parameters to the |
There was a problem hiding this comment.
| // IssueListByOrgOptions specifies the optional parameters to the | |
| // IssueListByOrgOptions specifies the optional parameter to the |
| return s.listIssues(ctx, u, opts) | ||
| } | ||
|
|
||
| func (s *IssuesService) listIssues(ctx context.Context, u string, opts *IssueListOptions) ([]*Issue, *Response, error) { |
There was a problem hiding this comment.
After the change, listIssues is used only in the IssuesService.List. So, let's merge listIssues and List functions.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3694 +/- ##
==========================================
- Coverage 91.12% 91.11% -0.02%
==========================================
Files 187 187
Lines 16640 16655 +15
==========================================
+ Hits 15164 15176 +12
- Misses 1291 1293 +2
- Partials 185 186 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 participants
BREAKING CHANGE:
ListByOrgnow usesIssueListByOrgOptionsinstead ofListOptions.we now can pass the
Typeof an issue to list issues for repo and orgs, so we can have a better filteringhttps://docs.github.com/en/rest/issues/issues?apiVersion=2022-11-28#list-repository-issues