Skip to content

Refactor: Rename _compute_new_headers to compute_merged_headers#1676

Open
Leah866814 wants to merge 1 commit intohttpie:masterfrom
Leah866814:refactoring-improvements
Open

Refactor: Rename _compute_new_headers to compute_merged_headers#1676
Leah866814 wants to merge 1 commit intohttpie:masterfrom
Leah866814:refactoring-improvements

Conversation

@Leah866814
Copy link

Overview

This PR includes refactoring to improve code quality and maintainability.

Refactorings Completed

Set I (Basic Refactorings)

  1. Rename Method: Renamed _compute_new_headers to compute_merged_headers in sessions.py
    • Better reflects the method's actual behavior (merging headers, not just computing new)
    • Improved method documentation
    • Location: httpie/sessions.py, line 205

Testing

  • ✅ All session-related tests passing (61 tests)
  • ✅ No breaking changes
  • ✅ Backward compatible

Context

This PR is part of the CSCI5308 (Adv Software Development) course assignment at Dalhousie University, focusing on code refactoring and open-source contribution.

Student: Yifei Wang (B01069596)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants