feat: Remove the urllib3 pinning#2482
feat: Remove the urllib3 pinning#2482k8s-ci-robot merged 1 commit intokubernetes-client:release-34.0from
Conversation
|
Welcome @sathieu! |
|
It should probably take #2477 into account? |
2.6.1 has been released which reverts the breaking change. Ref: #2477 (comment) |
Yes, to be clearer my suggestion is to yank/disallow 2.6.0 in the requirements |
|
I wonder when it will be released... |
|
@HenriBlacksmith I've excluded 2.6.0, sorry for the delay. |
|
could you please add the fix (!= 2.6.0) to the main branch too, so it can be included in 1.35 release. |
|
/assign |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sathieu, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Done in #2491 |
|
Thanks for merging @yliaog. Any ETA of a new 34.x (or 35.x) version? |
|
started 1.35 release in PR: #2492, the release will go through alpha, beta, and GA. It will complete in ~2 weeks. |
|
@yliaog Are you saying there will be no 1.34 version with this fix? |
What type of PR is this?
/kind feature
/kind regression
What this PR does / why we need it:
The PR removes the version pinning for the urllib3 library.
Same as #2461, for release-34 branch
Which issue(s) this PR fixes:
Fixes #2458 #2424
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: