Add Helm values to disable KueueViz ingress resources#8986
Add Helm values to disable KueueViz ingress resources#8986david-gang wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
Add kueueViz.backend.ingress.enabled and kueueViz.frontend.ingress.enabled options to allow users to disable ingress creation.
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: david-gang The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @david-gang. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add
kueueViz.backend.ingress.enabledandkueueViz.frontend.ingress.enabledHelm values to allow users to disable ingress creation when using alternative ingress solutions (e.g., IstioGateway/VirtualService).
Both options default to
truefor backwards compatibility.Which issue(s) this PR fixes:
Fixes #7659
Special notes for your reviewer:
The change is implemented via the yaml-processor in
hack/processing-plan.yaml. Helm unit tests have been added to verify the behavior.Does this PR introduce a user-facing change?