Conversation
|
Hey, I myself am not a Go programmer so I cannot comment on the code, though I will say it looks fine to me. I consider this a minor point: I noticed that the CONTRIBUTING file regex is hardcoded to write to that file, I was wondering if you would consider a flag for making the filename explicit (i.e. -filename blah.md). So for example I have a CONTRIBUTING.md file in Media Center that contains my Contributor's guide. I may call this ContributorsGuide.md or something to that effect; however, I do not know if all projects would necessarily want it appended into that file. Just a thought, I don't know if the other subcommands have that option to not hardcode the filename. I know for LICENSE it doesn't make much sense for that filename to be configurable, but perhaps here it does? |
|
Here is the text that the subcommand appends to
The code doesn't always write to |
|
Well yes, I meant the CONTRIBUTING/contributing filename itself being hardcoded, not the extension of that file. I suppose it's fine that way, do you know if any project would want to deviate from that? |
|
@kennymalac I'm sure some may, but AFAIK, GitHub only "supports" |
cc @kennymalac