Closed
Conversation
kuba-moo
requested changes
Aug 23, 2025
Contributor
kuba-moo
left a comment
kuba-moo
left a comment
There was a problem hiding this comment.
You should probably handle this automatically in the CodeWriter... it already auto-indents this stuff.
Please format the commits following kernel coding standards (Signed-off-by tags are needed).
Signed-off-by: Sheldon Wu <xzw2048@gmail.com>
Signed-off-by: Sheldon Wu <xzw2048@gmail.com>
sheldnwu
force-pushed
the
fix_miss_braces
branch
from
62b9656 to
2bd29ba
Compare
Contributor
Author
|
also Added Signed-off-by tags to the commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://clang.llvm.org/extra/clang-tidy/checks/readability/braces-around-statements.html
Clang Checks that bodies of if statements and loops (for, do while, and while) are inside braces. add this fix to address this requirements