Don't try to narrow type of a symbol within RHS of its declaration#63006
Open
Andarist wants to merge 9 commits intomicrosoft:mainfrom
Open
Don't try to narrow type of a symbol within RHS of its declaration#63006Andarist wants to merge 9 commits intomicrosoft:mainfrom
Andarist wants to merge 9 commits intomicrosoft:mainfrom
Conversation
typescript-bot
added
the
For Milestone Bug
Member
|
Do we need a different approach? Or can we just match? (Why the difference?) |
Contributor
Author
|
Strada can certainly match the Corsa’s patch. It’s just this PR predates the Corsa’s PR and given I managed to get rid of an existing node flag here, I figured out it might be interesting to leave it for review. Feel free to close this though. |
Member
|
Oh, I just want them to match; I don't think that a method that saves us a flag is bad, just trying to understand how to align things. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #62993
fixes #63044
fixes #63091
fixes #63093
it's using an alternative approach to microsoft/typescript-go#2542