Skip to content

Conversation

@DanielRosenwasser
Copy link
Member

Kind of weird to phrase these in this way, but for most users these are functionally true going forward.

Maybe it would feel less confusing if we said "true as long as strict is still enabled".

Copilot AI review requested due to automatic review settings February 4, 2026 20:48
@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Feb 4, 2026
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Feb 4, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the default value descriptions for strict-related compiler flags to more accurately reflect their behavior. The change improves clarity by stating that these flags default to true (unless strict is disabled) rather than the previous wording which suggested they default to false (unless strict is set).

Changes:

  • Updated the diagnostic message text from "false, unless strict is set" to "true, unless strict is disabled"
  • Applied this updated description to all 8 strict-related flags: noImplicitAny, strictNullChecks, strictFunctionTypes, strictBindCallApply, strictPropertyInitialization, strictBuiltinIteratorReturn, noImplicitThis, and useUnknownInCatchVariables
  • Updated the test baseline to reflect the new help output

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/compiler/diagnosticMessages.json Updates the diagnostic message definition used for strict flag defaults
src/compiler/commandLineParser.ts Updates all 8 strict flag options to reference the new diagnostic message
tests/baselines/reference/tsc/commandLine/help-all.js Updates the baseline to reflect the new default value descriptions in help output

},

"`false`, unless `strict` is set": {
"`true`, unless `strict` is disabled": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"`true`, unless `strict` is disabled": {
"`true`, unless `strict` is `false`": {

maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Status: Not started

Development

Successfully merging this pull request may close these issues.

3 participants