Closed
Conversation
…t/vscode-documentdb into dev/tnaum/migration-api
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an external API for migration extensions, expanding support for migration providers and integrating them into the DocumentDB extension. Key changes include:
- Creation of migration service implementations and API contracts for migration providers.
- Integration of a new “choose migration” command in the DocumentDB extension.
- Addition of API packaging, workflows, and localization updates to support migration features.
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/services/migrationServices.ts | Implements migration provider interfaces and a service singleton for provider registration and listing. |
| src/extension.ts | Updates the extension activation to expose a union API including migration features. |
| src/documentdb/ClustersExtension.ts | Registers the new command for choosing a migration extension. |
| src/commands/chooseDataMigrationExtension/chooseDataMigrationExtension.ts | Implements the command UI and logic to select and execute migration provider actions. |
| package.json, l10n/bundle.l10n.json | Adds new commands and localized strings for migration support. |
| api folder | Introduces API definitions, build configuration, and workflows for the migration extension API. |
Comments suppressed due to low confidence (3)
src/extension.ts:32
- The union return type for activateInternal may lead to ambiguity for API consumers; consider consolidating the API or clearly documenting the expected handling for each type.
): Promise<apiUtils.AzureExtensionApiProvider | DocumentDBExtensionApi> {
src/commands/chooseDataMigrationExtension/chooseDataMigrationExtension.ts:118
- Using a generic id like 'separator' may conflict if an actual provider uses this id; consider using a reserved prefix (for example, 'separator') to avoid potential conflicts.
{ id: 'separator', label: '', kind: QuickPickItemKind.Separator }
src/commands/chooseDataMigrationExtension/chooseDataMigrationExtension.ts:175
- The ensureAuthentication function currently returns false as a placeholder; consider adding tests or implementing the authentication flow to ensure proper coverage of migration provider actions that require authentication.
async function ensureAuthentication(_context: IActionContext, _node: ClusterItemBase): Promise<boolean> { ... }
Collaborator
Author
|
no longer tracking this PR, a new repo structure will be setup for features. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.