Skip to content

WIP: External API for migration extensions#132

Closed
tnaum-ms wants to merge 22 commits intomainfrom
dev/tnaum/migration-api
Closed

WIP: External API for migration extensions#132
tnaum-ms wants to merge 22 commits intomainfrom
dev/tnaum/migration-api

Conversation

@tnaum-ms
Copy link
Collaborator

@tnaum-ms tnaum-ms commented Jun 4, 2025

No description provided.

Copilot AI review requested due to automatic review settings June 4, 2025 15:56

This comment was marked as outdated.

@tnaum-ms tnaum-ms marked this pull request as draft June 5, 2025 16:26
@tnaum-ms tnaum-ms requested a review from Copilot June 5, 2025 16:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces an external API for migration extensions, expanding support for migration providers and integrating them into the DocumentDB extension. Key changes include:

  • Creation of migration service implementations and API contracts for migration providers.
  • Integration of a new “choose migration” command in the DocumentDB extension.
  • Addition of API packaging, workflows, and localization updates to support migration features.

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/services/migrationServices.ts Implements migration provider interfaces and a service singleton for provider registration and listing.
src/extension.ts Updates the extension activation to expose a union API including migration features.
src/documentdb/ClustersExtension.ts Registers the new command for choosing a migration extension.
src/commands/chooseDataMigrationExtension/chooseDataMigrationExtension.ts Implements the command UI and logic to select and execute migration provider actions.
package.json, l10n/bundle.l10n.json Adds new commands and localized strings for migration support.
api folder Introduces API definitions, build configuration, and workflows for the migration extension API.
Comments suppressed due to low confidence (3)

src/extension.ts:32

  • The union return type for activateInternal may lead to ambiguity for API consumers; consider consolidating the API or clearly documenting the expected handling for each type.
): Promise<apiUtils.AzureExtensionApiProvider | DocumentDBExtensionApi> {

src/commands/chooseDataMigrationExtension/chooseDataMigrationExtension.ts:118

  • Using a generic id like 'separator' may conflict if an actual provider uses this id; consider using a reserved prefix (for example, 'separator') to avoid potential conflicts.
{ id: 'separator', label: '', kind: QuickPickItemKind.Separator }

src/commands/chooseDataMigrationExtension/chooseDataMigrationExtension.ts:175

  • The ensureAuthentication function currently returns false as a placeholder; consider adding tests or implementing the authentication flow to ensure proper coverage of migration provider actions that require authentication.
async function ensureAuthentication(_context: IActionContext, _node: ClusterItemBase): Promise<boolean> { ... }

@tnaum-ms
Copy link
Collaborator Author

tnaum-ms commented Jun 6, 2025

no longer tracking this PR, a new repo structure will be setup for features.

@tnaum-ms tnaum-ms closed this Jun 6, 2025
@tnaum-ms tnaum-ms deleted the dev/tnaum/migration-api branch June 6, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant