Open
Conversation
added 2 commits
January 17, 2018 22:46
nmuldavin
requested changes
Apr 28, 2018
|
|
||
| first._name = 'first'; | ||
|
|
||
| export default first; |
Owner
There was a problem hiding this comment.
We'll need it to propagate errors and complete messages as well. What if it errors or completes before the first one?
| it('emits the first element of an Observable', () => { | ||
| expect(first(Observable.of(1, 2, 3))).to.eql(1); | ||
| }); | ||
| }); |
Owner
There was a problem hiding this comment.
you can add test cases for what I mentioned above
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am confident that I haven't yet grokked what I need to grok. Strictly speaking this code works, but it's smelly to me.