update opentelemetry-instrumentation to wrapt v2#4082
update opentelemetry-instrumentation to wrapt v2#4082MeggyCal wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
|
I am unsure about the necessity of this PR unless there are plans to update the version of wrapt, do we have any plans to use the new functionality from the major version? In turn, I am not sure allowing all versions of wrapt, i.e. |
|
I'm not worried on permitting a newer wrapt version but I'm worried that:
|
|
Having Wrapt hard locked to <2 is a blocking bug for me to be able to use OpenTelemetry at all in one of my critical applications. That application is using Wrapt 2 and that means I can't even install this package to be able to instrument the application. The application in question is https://github.com/openedx/openedx-platform |
|
Hi, I agree it would be nice to test this PR with wrapt 2 in several usecases. Sadly, I have almost no experience with automatic testing on GitHub, could someone please do it for me? This PR still preserves compatibility with wrapt 1, so I don't see why it would be breaking, unless there are more problems with wrapt 2. I agree changelog entry would be nice to have, I will try to add it. |
Description
Wrapt 2 introduced some changes in object wrappers (this blog summarizes it nicely).
This change at least allows tests to pass with wrapt 2.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I ran the testsuite of opentelemetry-instrumentation.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.