feat: Support persisting SQLite DB, and data refresher#233
Merged
lukehesluke merged 24 commits intomasterfrom Apr 7, 2025
Merged
feat: Support persisting SQLite DB, and data refresher#233lukehesluke merged 24 commits intomasterfrom
lukehesluke merged 24 commits intomasterfrom
Conversation
This reverts commit fa828f9.
lukehesluke
commented
Mar 5, 2025
| *fakedatabase.db | ||
|
|
||
| # Output path for app publishing | ||
| /web-app-package/ No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
I think this had accidentally entered the git repo at some point
lukehesluke
commented
Mar 5, 2025
| @@ -0,0 +1,70 @@ | |||
| using System; | |||
Contributor
Author
There was a problem hiding this comment.
This file is very similar to FakeDataRefresherService from #156, except with the following changes:
- Logs
- It informs DataRefresherStatusService when a has completed a cycle (which is explained in that file)
civsiv
reviewed
Mar 13, 2025
| typeof(SellerUserTable) | ||
| }; | ||
|
|
||
| private static readonly Type[] TableTypesToDrop = new [] |
Contributor
There was a problem hiding this comment.
Suggested change
| private static readonly Type[] TableTypesToDrop = new [] | |
| // This is TableTypesToCreate in reverse order | |
| private static readonly Type[] TableTypesToDrop = new [] |
Contributor
There was a problem hiding this comment.
I spent 30s wondering what was different between the two despite the comment below as I saw this first
civsiv
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on top of the changes from this PR: #156. The main difference is this:
I did not quite have time to set up CI tests for this (though this has been partially complete). So, that has been put into another (wip) PR: #237
Possible goals for a later date, which are not being pursued here (they would need sufficient usecase (e.g. use at scale) to be worth pursuing in a future issue):
QA
Using the CI script from #237: