Open
Conversation
The start script was checking for `EMPHEMERAL` rather than `EPHEMERAL` and thus always setting the default value of `--ephemeral`. I've also changed it to default to non ephemeral unless the caller specifically sets the `EPHEMERAL` environment variable which sounds clearer (so that if one doesn't want the runner to be ephemeral they just don't set the environment variable rather than having to instead set it to empty). Note that this will change the behavior of the runner for existing callers, not sure how you want to handle this.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The start script was checking for
EMPHEMERALrather thanEPHEMERALand thus always setting the default value of--ephemeral.I've also changed it to default to non ephemeral unless the caller specifically sets the
EPHEMERALenvironment variable which sounds clearer (so that if one doesn't want the runner to be ephemeral they just don't set the environment variable rather than having to instead set it to empty).Note that this will change the behavior of the runner for existing callers, not sure how you want to handle this.