[3.13] gh-74955: Document that __all__ must contain strings in normalization form NFKC (GH-144504) #144520
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zation form NFKC (pythonGH-144504) (cherry picked from commit c81e1843d4bc0a51cf4f77d19b5ac4e49f714a0d) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
| of strings which are names defined or imported by that module. The names | ||
| of strings which are names defined or imported by that module. | ||
| Names containing non-ASCII characters must be in the `normalization form`_ | ||
| NFKC; see :ref:`lexical-names-nonascii` for details. The names |
Member
There was a problem hiding this comment.
Suggested change
| NFKC; see :ref:`lexical-names-nonascii` for details. The names | |
| NFKC. The names |
It does not exist in 3.13
caje731
reviewed
Feb 6, 2026
| of strings which are names defined or imported by that module. The names | ||
| of strings which are names defined or imported by that module. | ||
| Names containing non-ASCII characters must be in the `normalization form`_ | ||
| NFKC; see :ref:`lexical-names-nonascii` for details. The names |
| namespace for a variable named ``__all__``; if defined, it must be a sequence | ||
| of strings which are names defined or imported by that module. The names | ||
| of strings which are names defined or imported by that module. | ||
| Names containing non-ASCII characters must be in the `normalization form`_ |
Contributor
There was a problem hiding this comment.
nit: repetition:
s/must be in the normalization form NFKC / must be in the Normalization Form KC/
or even
s/must be in the normalization form NFKC / must be in NFKC/
First reads well to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit c81e184)
Co-authored-by: Serhiy Storchaka storchaka@gmail.com
📚 Documentation preview 📚: https://cpython-previews--144520.org.readthedocs.build/