[mypyc] Add codegen support and compiled run tests for vecs#20737
Merged
[mypyc] Add codegen support and compiled run tests for vecs#20737
Conversation
p-sawicki
reviewed
Feb 4, 2026
mypyc/codegen/emitmodule.py
Outdated
| if any(LIBRT_TIME in mod.dependencies for mod in self.modules.values()): | ||
| ext_declarations.emit_line("#include <time/librt_time.h>") | ||
| if any(LIBRT_VECS in mod.dependencies for mod in self.modules.values()): | ||
| ext_declarations.emit_line('#include "vecs/librt_vecs.h"') |
Collaborator
There was a problem hiding this comment.
Suggested change
| ext_declarations.emit_line('#include "vecs/librt_vecs.h"') | |
| ext_declarations.emit_line('#include <vecs/librt_vecs.h>') |
for consistency
Comment on lines
+170
to
+177
| if int() + 1: | ||
| assert x is not None | ||
| assert len(x) == 1 | ||
| assert x[0] == 5 | ||
| if int() + 2: | ||
| assert isinstance(x, vec) | ||
| assert len(x) == 1 | ||
| assert x[0] == 5 |
Collaborator
There was a problem hiding this comment.
the if statements seem strange, what's the reason?
Comment on lines
229
to
232
| vv, x = pop(v) | ||
| assert vv == vec[vec[float]]() | ||
| assert x == vec[float]([1.5]) | ||
| v[0] = vec[float]([-2.5]) |
Collaborator
There was a problem hiding this comment.
isn't v[0] out of bounds?
mypyc/test-data/run-vecs-t.test
Outdated
| assert v2 == vec[str](["5"]) | ||
|
|
||
| o3: Any = vec[str]() | ||
| # TODO: Use str | None instead union |
for more information, see https://pre-commit.ci
p-sawicki
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now vecs work efficiently in compiled code (when experimental features are enabled).
This is the last big PR from my old vec branch. The following PRs will be more incremental.
Follow-up to #20732.
Related issue: mypyc/mypyc#840