Replace home class-based view with function based view.#27
Open
smajda wants to merge 1 commit intopythonkc:masterfrom
Open
Replace home class-based view with function based view.#27smajda wants to merge 1 commit intopythonkc:masterfrom
smajda wants to merge 1 commit intopythonkc:masterfrom
Conversation
Far easier to introduce to beginners to Django. Keeping both views around because it's nice to have two identical views in both styles to compare.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During our Saturday meeting we used this project and the home view as a simple "Intro to Django" view. Rather than digging right into the class-based view we currently use, we rewrote it as a function based view from scratch. For beginners, function-based views are much better.
I kept both views around in the file for reference, because that's nice to have.