refactor: singleton octokit instance for shared throttling state#640
refactor: singleton octokit instance for shared throttling state#640
octokit instance for shared throttling state#640Conversation
BREAKING CHANGE: `@semantic-release/github` is now a native ES Module
gr2m
force-pushed
the
beta-singleton-octokit
branch
from
e7f4f8f to
15a127b
Compare
gr2m
force-pushed
the
beta-singleton-octokit
branch
from
15a127b to
0893bef
Compare
gr2m
changed the title
octokit instance
gr2m
changed the title
octokit instance for shared throttling state
travi
left a comment
travi
left a comment
There was a problem hiding this comment.
i like where this is headed. only comments are calling out most of your todos. am i correct to assume that is most of what remains for this to still be draft, or do you have additional plans?
| }); | ||
|
|
||
| test.serial("Update a release with a custom github url", async (t) => { | ||
| // TODO: move to integration tests |
There was a problem hiding this comment.
is this a change that you are wanting to include in this PR?
| }); | ||
|
|
||
| test("Publish a release with one asset and custom github url", async (t) => { | ||
| // TODO: move to integration tests |
There was a problem hiding this comment.
is this a change you are wanting to include in this PR?
| }); | ||
|
|
||
| test("Publish a release when env.GITHUB_URL is set to https://github.com (Default in GitHub Actions, #268)", async (t) => { | ||
| // TODO: move to integration test |
There was a problem hiding this comment.
is this a change you are wanting to include in this PR?
| t.true(fetch.done()); | ||
| }); | ||
|
|
||
| // TODO: move to integration test |
There was a problem hiding this comment.
is this a change you are wanting to include in this PR?
|
are we wanting to include this refactor in the ESM change, or follow up with it afterward? i've had no problems in my testing with the current beta that includes the ESM change for our two candidate plugins, so wondering if we promote those candidates or wait for this change to go in |
correct
I planned to give this another go today but I won't have time. I'd say let's go ahead with the ESM change and then do this afterwards. |
2 participants
Uh oh!
There was an error while loading. Please reload this page.