Infer result type from result_type arg under string name overload#938
Open
dandavison wants to merge 1 commit intomainfrom
Open
Infer result type from result_type arg under string name overload#938dandavison wants to merge 1 commit intomainfrom
dandavison wants to merge 1 commit intomainfrom
Conversation
Contributor
dandavison
commented
Jul 3, 2025
dandavison
commented
dandavison
force-pushed
the
workflow-infer-type-from-result-type-arg
branch
from
b173c7f to
c665665
Compare
tconley1428
approved these changes
Jul 3, 2025
cretz
approved these changes
Jul 3, 2025
Member
cretz
left a comment
cretz
left a comment
There was a problem hiding this comment.
Should this also be done with workflow things like execute_activity, start_activity, execute_child_workflow, and start_child_workflow?
dandavison
force-pushed
the
workflow-infer-type-from-result-type-arg
branch
from
c665665 to
ba0303a
Compare
dandavison
force-pushed
the
workflow-infer-type-from-result-type-arg
branch
from
ba0303a to
1097275
Compare
dandavison
force-pushed
the
workflow-infer-type-from-result-type-arg
branch
from
1097275 to
b9ca006
Compare
Contributor
Author
Yes, opened #1077 to investigate. |
Contributor
Author
|
The reason this PR hasn't been merged is that it seems to cause mypy to demand type annotations on the LHS of assignments. See 6b0fe3eb9b45ee4eeca8cf8a62855f8e2ece10a1q |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.