Draft
Conversation
Reviewer's Guide by SourceryThe pull request improves the reliability of the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #577 +/- ##
=======================================
Coverage 79.83% 79.83%
=======================================
Files 22 22
Lines 1914 1914
Branches 294 294
=======================================
Hits 1528 1528
Misses 266 266
Partials 120 120 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c11f0dc to
ac631e0
Compare
why: Tests were failing when using fish shell due to prompt differences what: - Use PROMPT_COMMAND='' to clear shell-specific prompt commands - Set custom PS1='READY>' that works across shells - Add retry logic to wait for prompt and command output - Make assertions more flexible by checking content not exact matches
why: Test was flaky due to timing issues with shell initialization what: - Add small delay after window creation - Add error handling around capture_pane calls - Increase retry timeouts from 1s to 2s - Add more comprehensive output checks - Add check for non-empty pane contents
Add setup_shell_window helper function to standardize shell setup in tests: Set consistent shell environment and prompt, add robust waiting for shell readiness, handle environment variables consistently, prevent shell-specific prompt modifications. Update test_new_window_with_environment to use new helper: Add proper waiting for command output, fix linting issues with loop variables, make tests more reliable against timing issues.
ac631e0 to
82da140
Compare
0188aed to
ea5b0c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Improve shell interoperability in tests by using a consistent prompt across shells and adding retry logic to wait for the shell to be ready and for the command output to be available before asserting the pane contents.
Tests:
PROMPT_COMMANDandPS1to set a consistent prompt across shells.