Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #606 +/- ##
==========================================
+ Coverage 46.21% 46.45% +0.23%
==========================================
Files 19 19
Lines 1876 1890 +14
Branches 294 297 +3
==========================================
+ Hits 867 878 +11
- Misses 894 897 +3
Partials 115 115 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
237cb08 to
bf3b7f9
Compare
9957ba8 to
c5887b3
Compare
280026c to
9f069a4
Compare
why: Existing tests call _check_deprecated_version() directly, missing integration issues in the full call chain. what: - Add test_version_deprecation_via_get_version() that monkeypatches tmux_cmd and calls get_version() to verify warning plumbing - Tests the complete flow: tmux_cmd → version parsing → deprecation check
9f069a4 to
4ed7b79
Compare
Member
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
This was referenced Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate tmux versions below 3.2a
Summary
FutureWarning) for tmux versions below 3.2aTMUX_SOFT_MIN_VERSIONconstant for deprecation thresholdMotivation
tmux 3.2a was released in April 2021 and is the version shipped with Ubuntu 22.04 LTS. Older versions (3.1 and below) are only found on EOL platforms like Ubuntu 20.04. Deprecating these versions allows libtmux to:
format-defaults, extended hooks,display-menuAPIs)Changes
Source (
src/libtmux/common.py)TMUX_SOFT_MIN_VERSION: New constant set to"3.2a"- the deprecation threshold_version_deprecation_checked: Module-level flag ensuring warning fires only once per process_check_deprecated_version(): New helper function that emits aFutureWarningwhen tmux version is below 3.2aget_version(): Now calls_check_deprecated_version()to trigger warning on first version checkEnvironment Variable
Users can suppress the warning by setting:
export LIBTMUX_SUPPRESS_VERSION_WARNING=1Tests (
tests/test_common.py)Added parametrized tests using
NamedTuplefixture pattern:test_version_deprecation_warning- 5 parametrized cases covering deprecated versions, current versions, and env var suppressiontest_version_deprecation_warns_once- Verifies warning only fires once per processtest_version_deprecation_via_get_version- Integration test verifying warning through fullget_version()call chainDocumentation
docs/quickstart.md: Updated Requirements section with version recommendations and deprecation noteCHANGES: Added Deprecations and Internal sections for 0.48.xFuture Work
In a future release (e.g., 0.49.0 or 0.50.0):
TMUX_MIN_VERSIONfrom"1.8"to"3.2a"_check_deprecated_version()helper andTMUX_SOFT_MIN_VERSIONSee Also
This facilitates upcoming changes: