[css-gaps-1] Change decorations to be segments based rather than intersections based #12784 #13299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbabbitt
reviewed
Jan 7, 2026
Collaborator
kbabbitt
left a comment
kbabbitt
left a comment
There was a problem hiding this comment.
Thanks for working on this! Left a round of comments, though I'm not positive I caught everything.
One other note: I fetched the branch, ran Bikeshed on this file, and noticed a number of new warnings. I'd like to keep this file Bikeshed clean with the exception of warnings for new WPTs that haven't been added yet.
Updated section headings to clarify proposed solutions and added pros and cons of the different solutions.
… definition in CSS Color 4 w3c#13286
This adds a named ViewTimeline range of 'scroll' as resolved[1] on. [1] w3c#9367 (comment) Co-authored-by: David Awogbemila <[email protected]>
Collaborator
|
Live preview: https://osamdavis.github.io/css-spec-host/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves gap decorations to be "segments" based rather than "intersections" based. TODO add more context.
Live preview: https://jav099.github.io/spec-host/