-
Notifications
You must be signed in to change notification settings - Fork 65
Common Definitions Simplification #2173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a6c69d4
change examples to bf proposal
egekorkan ab1005a
update proposal readme with the simplification
egekorkan e1bb3d4
chore: run format
egekorkan 4f6228e
add review feedback and adjust documentation
egekorkan 7546889
Update proposals/common-definitions/README.md
egekorkan 6edf373
add expanded examples and alternatives to example 1
egekorkan bd822a0
add expanded versions of all examples
egekorkan 4998a7e
rearrange tests to use expanded and compacted at the same array
egekorkan 4e247c8
bugfix: fix imports
egekorkan 3855a80
adapt test cases
egekorkan 923cf99
chore: run format
egekorkan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feedback from @relu91 : What about having
hrefin a form definition and in none of the forms in the compact TD. That would be relevant for WebThing WS subprotocol or any protocol where the resource identifier is the same as affordance name. This can be relevant for defining the default for http binding where the Thing has pattern ofproperties/myPropertyName. Relevant to address #2087Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, currently the
formsmember of an InteractionAffordance is mandatory, can not be an empty array andhrefis a mandatory member of Form. This means that even if thehrefis the same as the default for every Form you would have to include ahrefwith the same value in every Form. IfformDefaultsis specified then maybeformsandhrefshould not be mandatory.This is usually not the case in the Web Thing Protocol WebSocket sub-protocol, where the same URL is usually used for all affordances of a Thing.
The URL structure is (intentionally) not specified in the HTTP Basic Profile,
hrefcan not be auto-generated from an affordance name. I don't think the default HTTP binding should prescribe a particular URL structure either.