docs: improving typos in ISSUE_TEMPLATE files#235
Merged
snitin315 merged 7 commits intowebpack:masterfrom Jun 30, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #235 +/- ##
==========================================
- Coverage 21.23% 14.75% -6.48%
==========================================
Files 8 9 +1
Lines 504 732 +228
Branches 108 168 +60
==========================================
+ Hits 107 108 +1
- Misses 348 543 +195
- Partials 49 81 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
snitin315
reviewed
Jun 30, 2025
Comment on lines
61
to
71
| // Todo fix me | ||
| data: this.data, | ||
| hot: this.hot, | ||
| cacheable: typeof this.cacheable, | ||
| emitWarning: typeof this.emitWarning, | ||
| emitError: typeof this.emitError, | ||
| resolve: typeof this.resolve, | ||
| getResolve: typeof this.getResolve, | ||
| getLogger: typeof this.getLogger, | ||
| // Todo fix me | ||
| emitFile: typeof this.emitFile, |
Member
There was a problem hiding this comment.
Why did we remove this? Can you please revert this change?
snitin315
reviewed
Jun 30, 2025
| @@ -19,7 +19,7 @@ test("Processes sass-loader's @import correctly", (done) => { | |||
| expect(stats.hasErrors()).toBe(false); | |||
Member
There was a problem hiding this comment.
I think we can revert changes to this file as well.
snitin315
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
improving typos in ISSUE_TEMPLATE files
Breaking Changes
No
Additional Info
No